Make amount of shown ports configurable #1113
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it is hardcoded to '4' which is suboptimal for bigger screens. Add a new flag to trex-console, `-m` that allows to specify amount of ports user want to see. Keep default value as 4 for compatibility reasons. Related to cisco-system-traffic-generator#1109
That is a quick way to get MIN_COLS check to work again However in case `-m 0` or `-m -1` specified (all ports), check won't be adjusted to actual number of ports available on a system
|
Checked SHA: 411efc8 |
|
@Civil seems as a good idea, I will rebase it |
|
Any updates on that? And also on #1112 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it is hardcoded to '4' which is suboptimal for bigger screens. Add a new flag to trex-console,
-mthat allows to specify amount of ports user want to see.Keep default value as 4 for compatibility reasons.
Related to #1109