Add PG_MODULE_MAGIC_EXT macro for Citus and citus columnar #8438
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8438 +/- ##
==========================================
- Coverage 88.79% 88.78% -0.01%
==========================================
Files 287 287
Lines 63237 63240 +3
Branches 7927 7928 +1
==========================================
- Hits 56152 56150 -2
- Misses 4753 4758 +5
Partials 2332 2332 🚀 New features to boost your workflow:
|
naisila
changed the title
naisila
changed the title
24 tasks
naisila
force-pushed
the
naisila/pg18_pg_module_magic_ext
branch
2 times, most recently
from
0ccc18b to
24e6076
Compare
m3hm3t
approved these changes
Jan 5, 2026
colm-mchugh
reviewed
Jan 5, 2026
|
|
||
| /* marks shared object as one loadable by the postgres version compiled against */ | ||
| #if PG_VERSION_NUM >= PG_VERSION_18 | ||
| PG_MODULE_MAGIC_EXT(.name = "citus", .version = "14.0devel"); |
Contributor
There was a problem hiding this comment.
Presumably the .version value needs to be updated with each new citus release (?)
Member
Author
There was a problem hiding this comment.
Could also use CITUS_VERSION_STR to avoid the hassle, let me take a second look at that
Member
Author
There was a problem hiding this comment.
CITUS_VERSION_STR doesn't look that good, so better to update this everytime we bump the citus version
colm-mchugh
approved these changes
Jan 5, 2026
Relevant PG18 commit: postgres/postgres@9324c8c58 Add the same for citus_columnar as well. Test this by the new PG18 pg_get_loaded_modules() function.
naisila
force-pushed
the
naisila/pg18_pg_module_magic_ext
branch
from
24e6076 to
3bf426e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PG18 commit:
postgres/postgres@9324c8c58
This commit adds PG_MODULE_MAGIC_EXT info for
citusandcitus_columnar.Tested this by the new PG18
pg_get_loaded_modules()function.Fixes #8417
Note: this should be taken care of every time we release a new version and bump the citus version.