Skip to content

Fix Nix and test it in CI (copy #2964) #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: 1.8
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 10, 2025

Our dependencies for the Nix flake were not correctly declared. This could happen because our CI job for Nix actually only tries to build clash-ghc, but the problems are in packages that clash-ghc does not depend on. So change CI to actually try to build all our packages, and run any test suites they have. (Just Cabal test-suites, not the executable clash-testsuite).

Still TODO:

  • Write a changelog entry (see changelog/README.md)
  • Check copyright notices are up to date in edited files
    This is an automatic copy of pull request Fix Nix and test it in CI #2964 done by Mergify.

(cherry picked from commit 10cb1da)

# Conflicts:
#	nix/overlay-ghc910.nix
(cherry picked from commit 583b32e)
Switched to "new-style" `nix build` instead of `nix-build` with a dash.
Build all derivations we define instead of only building clash-ghc and
its dependencies, which was the previous behaviour of this CI job.

(cherry picked from commit 97d5b61)
Copy link
Contributor Author

mergify bot commented Jun 10, 2025

Cherry-pick of 10cb1da has failed:

On branch mergify/copy/1.8/pr-2964
Your branch is up to date with 'origin/1.8'.

You are currently cherry-picking commit 10cb1da6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   nix/overlay-ghc910.nix

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant