Upgrade sphinx 1.2.2 -> 8.1.3 #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The interface to fetch_inventory changed around the 7-8 major version to take a Sphinx config object. However, we're not working with a sphinx site and just want it to load and parse an inventory file for us. Luckily, the project ships the InventoryFile class which provides an interface to do exactly this.
meshy
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't seem to break the site, so I suspect whatever stopped us from upgrading previously has been solved in a subsequent version.
I ran:
Then checked both the docs and source code URLs work locally. Have I missed any places to test?