Skip to content

fix(clerk-js): Display alert on plan details error #6384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 31, 2025
Merged

fix(clerk-js): Display alert on plan details error #6384

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01eb35a
fix(clerk-js): Display alert on plan details error
panteliselef Jul 24, 2025
9edfad5
fix(clerk-js): Display alert on plan details error
panteliselef Jul 24, 2025
4f648b2
address feedback
panteliselef Jul 24, 2025
12a55c1
Merge branch 'main' into elef/com-1068-handle-plan-not-found-in-pland…
panteliselef Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions packages/clerk-js/src/ui/components/Plans/PlanDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,19 @@ export const PlanDetails = (props: __internal_PlanDetailsProps) => {

const BodyFiller = ({ children }: { children: React.ReactNode }) => {
return (
<Drawer.Body>
<Flex
align={'center'}
justify={'center'}
sx={t => ({
height: '100%',
padding: t.space.$4,
fontSize: t.fontSizes.$md,
})}
>
{children}
</Flex>
<Drawer.Body
sx={t => ({
display: 'flex',
flexDirection: 'column',
alignItems: 'center',
justifyContent: 'center',
flex: 1,
overflowY: 'auto',
Comment on lines +43 to +48
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

body already handles a majority of these.

javascript/packages/clerk-js/src/ui/elements/Drawer.tsx

Lines 351 to 355 in 79b4f03

display: 'flex',
flexDirection: 'column',
flex: 1,
overflowY: 'auto',
overflowX: 'hidden',

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not inherited tho. If i removed the duplicate ones then this is the UI I end up with.
image

padding: t.space.$4,
gap: t.space.$4,
})}
>
{children}
</Drawer.Body>
);
};
Expand Down
Loading