Skip to content

fix(clerk-js): Updates social button label logic #7104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

fix(clerk-js): Updates social button label logic #7104

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bd456d7
fix(clerk-js): Updates social button label logic
alexcarpenter Oct 30, 2025
6efbf9a
add changeset
alexcarpenter Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/clerk-js/src/ui/components/SignIn/SignInSocialButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export const SignInSocialButtons = React.memo((props: SignInSocialButtonsProps)
return (
<SocialButtons
{...rest}
showLastAuthenticationStrategy={true}
showLastAuthenticationStrategy
idleAfterDelay={!shouldUsePopup}
oauthCallback={strategy => {
if (shouldUsePopup) {
Expand Down
10 changes: 7 additions & 3 deletions packages/clerk-js/src/ui/elements/SocialButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,14 @@ export const SocialButtons = React.memo((props: SocialButtonsRootProps) => {
);
const strategyRowOneLength = strategyRows.at(lastAuthenticationStrategyPresent ? 1 : 0)?.length ?? 0;

const remainingStrategiesCount = lastAuthenticationStrategy ? strategies.length - 1 : strategies.length;

const preferBlockButtons =
socialButtonsVariant === 'blockButton'
? true
: socialButtonsVariant === 'iconButton'
? false
: strategies.length <= SOCIAL_BUTTON_BLOCK_THRESHOLD;
: remainingStrategiesCount <= SOCIAL_BUTTON_BLOCK_THRESHOLD;

const startOauth = async (strategy: OAuthStrategy | Web3Strategy) => {
card.setLoading(strategy);
Expand Down Expand Up @@ -160,13 +162,15 @@ export const SocialButtons = React.memo((props: SocialButtonsRootProps) => {
})}
>
{row.map(strategy => {
const isLastAuthButton = strategy === lastAuthenticationStrategy;

const label =
strategies.length === SOCIAL_BUTTON_PRE_TEXT_THRESHOLD
isLastAuthButton || remainingStrategiesCount === SOCIAL_BUTTON_PRE_TEXT_THRESHOLD
? `Continue with ${strategyToDisplayData[strategy].name}`
: strategyToDisplayData[strategy].name;

const localizedText =
strategies.length === SOCIAL_BUTTON_PRE_TEXT_THRESHOLD
isLastAuthButton || remainingStrategiesCount === SOCIAL_BUTTON_PRE_TEXT_THRESHOLD
? localizationKeys('socialButtonsBlockButton', {
provider: strategyToDisplayData[strategy].name,
})
Expand Down
Loading
Loading