Skip to content

Conversation

@Shubham8287
Copy link
Contributor

Description of Changes.

fixes #3715

The patch makes snapshots to skip ephemeral tables.

API and ABI breaking changes

NA

Expected complexity level and risk

1

Testing

Copy link
Collaborator

@joshua-spacetime joshua-spacetime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test that previously would have snapshotted a view table before you merge?

@bfops bfops added the release-any To be landed in any release window label Nov 24, 2025
@joshua-spacetime
Copy link
Collaborator

We sometimes see failures for test_view_tables_are_ephemeral like this one here. I believe this is due to the fact that we're currently snapshotting ephemeral tables (before this fix). Do you concur @Shubham8287?

@Shubham8287
Copy link
Contributor Author

yeah, as per logs, It looks like due to snapshot, I wasn't aware this test can do snapshotting:

[INFO  spacetimedb::db::relational_db] [0000000000000000000000000000000000000000000000000000000000000000] DATABASE: durable_tx_offset is Some(3)
[INFO  spacetimedb::db::relational_db] [0000000000000000000000000000000000000000000000000000000000000000] DATABASE: restoring snapshot of tx_offset 3
[INFO  spacetimedb::db::relational_db] [0000000000000000000000000000000000000000000000000000000000000000] DATABASE: read snapshot of tx_offset 3 in 4.710688ms
[INFO  spacetimedb::db::relational_db] [0000000000000000000000000000000000000000000000000000000000000000] DATABASE: restored from snapshot of tx_offset 3 in 169.677µs
[INFO  spacetimedb::db::relational_db] [0000000000000000000000000000000000000000000000000000000000000000] DATABASE: applying transaction history...
[DEBUG spacetimedb_co

@joshua-spacetime
Copy link
Collaborator

Could you add a test that previously would have snapshotted a view table before you merge?

If we want to test with views specifically this would have to be a smoketest, but we can't control snapshotting from a smoketest. So I'm fine if you just want to use test_view_tables_are_ephemeral as a suitable regression test. It definitely shouldn't be flaky anymore after this change lands.

@Shubham8287 Shubham8287 added this pull request to the merge queue Dec 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 5, 2025
@Shubham8287 Shubham8287 added this pull request to the merge queue Dec 5, 2025
Merged via the queue into master with commit 013b202 Dec 5, 2025
39 of 40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-any To be landed in any release window

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Snapshots should ignore ephemeral tables

4 participants