-
Notifications
You must be signed in to change notification settings - Fork 651
Views: snapshot to skip ephermeral tables #3720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joshua-spacetime
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test that previously would have snapshotted a view table before you merge?
|
We sometimes see failures for |
|
yeah, as per logs, It looks like due to snapshot, I wasn't aware this test can do snapshotting: |
If we want to test with views specifically this would have to be a smoketest, but we can't control snapshotting from a smoketest. So I'm fine if you just want to use |
Description of Changes.
fixes #3715
The patch makes snapshots to skip ephemeral tables.
API and ABI breaking changes
NA
Expected complexity level and risk
1
Testing