Allowed specifying hex strings in the Postgres escape format #3756
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ) -> Result<R, hex::FromHexError> { | ||
| let hex = hex.as_ref(); | ||
| let hex = if hex.starts_with(b"0x") { | ||
| let hex = if hex.starts_with(b"0x") || hex.starts_with(b"\\x") { |
Collaborator
There was a problem hiding this comment.
This check needs to be in its own branch to account for enclosing delimiters.
Contributor
Author
There was a problem hiding this comment.
What are those? The escaped literal goes: \xAABBCCDD, with no tail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
For consistency with the PG Wire output format for
BYTEA.Before,
gave:
API and ABI breaking changes
None.
Expected complexity level and risk
1:
Trivial change.
Testing