Skip to content

Conversation

@Hax7
Copy link

@Hax7 Hax7 commented Feb 15, 2024

what

  • Fixed IAM policies and roles names to have user name because fixed names will prevent policy/role creation since it will be exist
  • Fixed users ssh resource to have for_each and point to the correct public key and user name
  • Add setting custom domain for SFTP server using transfer:customHostname tag
  • deprecate var.enable_sftp in favour of var.enabled

why

  • General improvements and cleaner usage

Copy link
Member

@themaniskshah themaniskshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@vaibhav7797 vaibhav7797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@theprashantyadav theprashantyadav requested review from theprashantyadav and removed request for theprashantyadav February 21, 2024 08:42
@Hax7
Copy link
Author

Hax7 commented Feb 21, 2024

I think I still need to update the examples and add details about how to use directory mapping for restricted home directory, it's not clear in the docs and i had to dig in the code for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants