chore: rm custom CODEOWNERS logic #27422
Open
+3
−643
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the custom CODEOWNERS logic that results in assignees being added to PRs. The standard GitHub logic around CODEOWNERS already does this, but with required reviewers instead.
From what I can tell, there is no advantage of assignee over required reviewer.
If the main benefit of this custom logic is that the assignee field gets marginally better treatment from the GitHub UI than reviewer, it makes sense to nuke this and rely on GitHub's standard CODEOWNER functionality. This avoids the ongoing cost of maintenance for this code for a small benefit. I'll be giving a quick walkthrough of the oddities in GitHub's UI to the team to ease adoption.