Run alarm without syncing alarm manager if currentTime past local time #5764
+76
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, if a SQLite DOs local alarm time in SQLite didn't match the AlarmManager's alarm time, we would reschedule the alarm and try to run the alarm again later. However, if the time we are attempting to sync to is already before the current real system time, there is no point in rescheduling to run later, since we might as well run now. This commit runs the alarm immediately if the current system time is already past the time we are trying to sync the alarm manager to, since it's better to run an alarm a little late rather than very late.
MellowYarker
force-pushed
the
milan/STOR-4832
branch
from
7f13363 to
4d1e592
Compare
a-robinson
approved these changes
Jan 5, 2026
| static constexpr kj::Date fourMs = 4 * kj::MILLISECONDS + kj::UNIX_EPOCH; | ||
| static constexpr kj::Date fiveMs = 5 * kj::MILLISECONDS + kj::UNIX_EPOCH; | ||
| // Used as the "current time" parameter for armAlarmHandler in tests. | ||
| // Set to epoch (before all test alarm times) so existing tests aren't affected by |
Member
There was a problem hiding this comment.
Making sure existing tests aren't affected is great, but is this new behavior worth covering with a new test case?
| // If the local alarm time is already in the past, just run the handler now. This avoids | ||
| // blocking alarm execution on storage sync when storage is overloaded. The alarm will | ||
| // either delete itself on success or reschedule on failure. | ||
| if (localAlarmState != kj::none && willFireEarlier(localAlarmState, currentTime)) { |
Member
There was a problem hiding this comment.
Given that this code block appears to be identical both here and below, can it just be moved up above the if (willFireEarlier(scheduledTime, localAlarmState)) { ... } else { ...} block rather than being repeated in both the if and the else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, if a SQLite DOs local alarm time in SQLite didn't match the AlarmManager's alarm time, we would reschedule the alarm and try to run the alarm again later.
However, if the time we are attempting to sync to is already before the current real system time, there is no point in rescheduling to run later, since we might as well run now.
This commit runs the alarm immediately if the current system time is already past the time we are trying to sync the alarm manager to, since it's better to run an alarm a little late rather than very late.