Revert "Noble VMs on AWS don't have /dev/sdX devices for some reason." #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6dd55d5.
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
fmoehler
requested review from
a team,
KauzClay and
ragaskar
and removed request for
a team
aramprice
moved this from Inbox
to Pending Review | Discussion
in Foundational Infrastructure Working Group
aramprice
approved these changes
Dec 11, 2025
github-project-automation
bot
moved this from Pending Review | Discussion
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 6dd55d5.
The underlying issue is fixed with cloudfoundry/bosh-linux-stemcell-builder#462 which makes this change obsolete. However it shall only be merged after the stemcell builder change is in to avoid permanently failing device resolution issues.
In short: the change in the stemcell builder fixes the creation of the symlink from the device_name defined by the cpi (e.g. /dev/sdb) to the nvme device name (e.g. /dev/nvme1n1). Therefore a separate mapping for nvme devices is not needed anymore.