Skip to content

Fixes from request spec validation #1034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Samze merged 1 commit into from
Aug 27, 2025
Merged

Fixes from request spec validation #1034

Samze merged 1 commit into from
Aug 27, 2025

Conversation

@Samze
Copy link
Contributor

@Samze Samze commented Aug 26, 2025 •
edited
Loading

Before


Validation Summary:
2025/08/26 14:15:33 Total requests: 7739
2025/08/26 14:15:33 Valid requests: 4724
2025/08/26 14:15:33 Invalid requests: 3004

After

Validation Summary:
2025/08/26 14:16:36 Total requests: 7739
2025/08/26 14:16:36 Valid requests: 7385
2025/08/26 14:16:36 Invalid requests: 343

@Samze Samze force-pushed the request_spec_fixes branch 2 times, most recently from 5625dda to d4cfa08 Compare August 27, 2025 20:53
@Samze Samze force-pushed the request_spec_fixes branch from d4cfa08 to 4ba4745 Compare August 27, 2025 20:57
@Samze Samze marked this pull request as ready for review August 27, 2025 21:04
@Samze Samze requested a review from FloThinksPi August 27, 2025 21:10
anujc25
anujc25 approved these changes Aug 27, 2025
View reviewed changes
Copy link
Contributor

@anujc25 anujc25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

@Samze Samze merged commit 1858881 into main Aug 27, 2025
2 checks passed
@anujc25
Copy link
Contributor

anujc25 commented Aug 27, 2025

These are identified based on #1033

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FloThinksPi FloThinksPi Awaiting requested review from FloThinksPi

1 more reviewer

@anujc25 anujc25 anujc25 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Samze @anujc25