Upgrade protobuf #4359
Merged
Upgrade protobuf #4359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svkrieger
force-pushed
the
upgrade-protobuf
branch
4 times, most recently
from
6668afd to
1487c93
Compare
svkrieger
force-pushed
the
upgrade-protobuf
branch
from
1487c93 to
f624486
Compare
svkrieger
force-pushed
the
upgrade-protobuf
branch
from
e1f03eb to
d5edf81
Compare
…regator and locket
svkrieger
force-pushed
the
upgrade-protobuf
branch
from
d5edf81 to
5efea14
Compare
philippthun
approved these changes
May 20, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
May 20, 2025
Changes in cloud_controller_ng:
- Upgrade protobuf
PR: cloudfoundry/cloud_controller_ng#4359
Author: Sven Krieger <37476281+svkrieger@users.noreply.github.com>
Dependency updates in cloud_controller_ng:
- build(deps-dev): bump solargraph from 0.54.4 to 0.54.5
PR: cloudfoundry/cloud_controller_ng#4363
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
philippthun
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Jun 11, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and default values are now being omitted. Thus the update of Protobuf libraries [2] led to an incompatible change as the Cloud Controller returned "null" instead of "0" for the external and internal ports as part of the process stats endpoint. With this change the hash is created manually by accessing all fields in the Protobuf object(s) directly. [1] protocolbuffers/protobuf#15234 [2] cloudfoundry#4359
5 tasks
philippthun
added a commit
to sap-contributions/cloud_controller_ng
that referenced
this pull request
Jun 11, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and default values are now being omitted. Thus the update of Protobuf libraries [2] led to an incompatible change as the Cloud Controller returned "null" instead of "0" for the external and internal ports as part of the process stats endpoint. With this change the hash is created manually by accessing all fields in the Protobuf object(s) directly. [1] protocolbuffers/protobuf#15234 [2] cloudfoundry#4359
philippthun
added a commit
that referenced
this pull request
Jun 12, 2025
The behavior of 'to_h' for Protobuf objects changed [1]; unset and default values are now being omitted. Thus the update of Protobuf libraries [2] led to an incompatible change as the Cloud Controller returned "null" instead of "0" for the external and internal ports as part of the process stats endpoint. With this change the hash is created manually by accessing all fields in the Protobuf object(s) directly. [1] protocolbuffers/protobuf#15234 [2] #4359
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short explanation of the proposed change:
googleapis-common-protosto newest version including its dependencies.The format of the proto files changed to something rather unreadable. This change was already introduced to protobuf's ruby code generator back in 2023: https://protobuf.dev/news/2023-04-20/
Links to any other associated PRs
Dependebot PR #4329 can be closed afterwards as the dependency is being bumped here.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests