feat: Add structured logging #502
Draft
+29
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses the new structured logger in lieu of the standard logger. cmd/gateway: - Inits structured logger to a text handler that outputs to stderr. - Panics instead of logging fatally if config cannot be loaded. - If config cannot be written out to stderr, logs an error instead of logging fatally. - Passes the handler to lower packages in the guise of standard logger. internal/gateway: - Uses default slog for logging, will inherit the slog from cmd/gateway. - Tests set slog output to GinkgoWriter so that logs are only output on test failures. - Removes unnecessary WithGatewayLogger option. - Panics instead of logging fatally in several cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds structured logging to Log Cache. Always outputs logs using RFC3339 timestamps.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branchIf you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack