Chore/fix go bump tnz 72735 #91
Open
+254
−196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplifies the dependency chain for this integration test and avoids a new go vet error observed when bumping to the latest docker libraries. Now this test uses a thin wrapper around the docker cli and does not require a Go docker library + a long tail of transitive dependencies. [TNZ-72735](https://vmw-jira.broadcom.net/browse/TNZ-72735)
percona 5.7 docker images don't contain "mysqladmin" tool used by 8.x healthchecks, so special-case an alternate. [TNZ-72735](https://vmw-jira.broadcom.net/browse/TNZ-72735) Authored-by: Kim Bassett <kim.bassett@broadcom.com>
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
kimago
force-pushed
the
chore/fix-go-bump-TNZ-72735
branch
from
cbac94e to
9375a6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for opening a PR. Please make sure you've read and followed the Contributing guide, including signing the Contributor License Agreement.
Feature or Bug Description
Motivation
Allow
go vetto pass in environments where docker test libraries were causing it to fail, by removing use of those libraries.https://vmw-jira.broadcom.net/browse/TNZ-72735
(Backports to v1.1 work done here, plus one additional commit to provide a 5.7-compatible healthcheck.)