Skip to content

Commit fcb3ff3

Browse files
committed
Merge branch 'chore/add-todos' into 'master'
chore(services): add todos for serivces with data needs See merge request auto-cloud/cloudgraph/provider/cloudgraph-provider-aws!230
2 parents c0d41bb + 5c556d8 commit fcb3ff3

File tree

25 files changed

+56
-6
lines changed

25 files changed

+56
-6
lines changed

src/services/appSync/schema.graphql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,9 @@ type awsAdditionalAuthenticationProvider
124124
userPoolAwsRegion: String @search(by: [hash, regexp])
125125
userPoolAppIdClientRegex: String @search(by: [hash, regexp])
126126
}
127-
127+
# TODO: add iam role connection
128+
# TODO: waf web acl connection
129+
# TODO: add cloudwatchLog connection
128130
type awsAppSync @key(fields: "arn") {
129131
id: String! @id @search(by: [hash])
130132
accountId: String! @search(by: [hash])

src/services/asg/schema.graphql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ type awsLaunchConfiguration
9393
metadataOptHttpEndpoint: String @search(by: [hash, regexp])
9494
}
9595

96+
#TODO: add iam role connection here
9697
type awsAsg @key(fields: "arn") {
9798
id: String! @search(by: [hash])
9899
accountId: String! @search(by: [hash])

src/services/cloudFormationStackSet/schema.graphql

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ type awsCloudFormationStackAutoDeploymentConfig {
4040
enabled: String @search(by: [hash, regexp])
4141
retainStacksOnAccountRemoval: String @search(by: [hash, regexp])
4242
}
43-
# add accountId to cloudFormationStackSet
43+
# TODO: add accountId to cloudFormationStackSet
4444
type awsCloudFormationStackSet @key(fields: "arn") {
4545
id: String! @search(by: [hash])
4646
arn: String! @id @search(by: [hash, regexp])
@@ -59,3 +59,5 @@ type awsCloudFormationStackSet @key(fields: "arn") {
5959
permissionModel: String @search(by: [hash, regexp])
6060
organizationalUnitIds: [String] @search
6161
}
62+
63+
# TODO: add iam role connection using AdministrationRoleARN (also see if a connection can be made using ExecutionRoleName)

src/services/cloudtrail/schema.graphql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ type awsCloudtrail @key(fields: "cgId") {
1212
homeRegion: String @search(by: [hash, regexp])
1313
logFileValidationEnabled: String @search(by: [hash, regexp])
1414
cloudWatchLogsLogGroupArn: String @search(by: [hash, regexp])
15-
cloudWatchLogsRoleArn: String @search(by: [hash, regexp])
15+
cloudWatchLogsRoleArn: String @search(by: [hash, regexp]) # add iamRole connection here
1616
kmsKeyId: String @search(by: [hash, regexp])
1717
hasCustomEventSelectors: String @search(by: [hash, regexp])
1818
hasInsightSelectors: String @search(by: [hash, regexp])

src/services/cognitoIdentityPool/schema.graphql

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,7 @@ type awsCognitoIdentityPool @key(fields: "id") {
3434
samlProviderARNs: [String] @search
3535
tags: [awsRawTag]
3636
}
37+
38+
# TODO: add an arn for identity pool see here: https://docs.aws.amazon.com/cognito/latest/developerguide/security_iam_service-with-iam.html
39+
#TODO: add connections to iamSamlProvider and iamOpenIdConnectProvider
40+
#TODO: try to add connection to iam role using getIdentityPoolRoles

src/services/cognitoUserPool/schema.graphql

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,3 +118,6 @@ type awsCognitoUserPool @key(fields: "id") {
118118
lambda: [awsLambda] @hasInverse(field: cognitoUserPool) #change to plural
119119
appSync: [awsAppSync] @hasInverse(field: cognitoUserPool)
120120
}
121+
122+
# TODO: add connetion to kms
123+
# TODO: add connection to iamRole using SmsConfiguration.SnsCallerArn

src/services/dynamodb/schema.graphql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -174,3 +174,5 @@ type awsDynamoDbTable @key(fields: "arn") {
174174
ttlEnabled: Boolean @search
175175
appSync: [awsAppSync] @hasInverse(field: dynamodb)
176176
}
177+
178+
#TODO: create conenction to iam roles using autoscalingRoleArn, also connect to KMS

src/services/ec2/schema.graphql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ type awsEc2 @key(fields: "arn") {
9696
sourceDestCheck: String @search(by: [hash, regexp])
9797
availabilityZone: String @search(by: [hash, regexp])
9898
cpuThreadsPerCore: Int @search
99-
iamInstanceProfile: String @search(by: [hash, regexp]) # TODO: use to make a connection to a role
99+
iamInstanceProfile: String @search(by: [hash, regexp]) # TODO: use to make a connection to a iamRole
100100
deletionProtection: String @search(by: [hash, regexp])
101101
dailyCost: awsTotalBillingInfo
102102
primaryNetworkInterface: String @search(by: [hash, regexp])

src/services/ecsCluster/schema.graphql

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ type awsEcsCluster @key(fields: "arn") {
2121
ecsTaskSet: [awsEcsTaskSet] @hasInverse(field: ecsCluster)
2222
}
2323

24+
#TODO: add connections to cloudwatchLog, s3,
25+
2426
type AwsEcsExecuteCommandLogConfiguration
2527
@generate(
2628
query: { get: false, query: true, aggregate: false }

src/services/ecsTask/schema.graphql

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
#TODO: add iam role connection
12
type awsEcsTask @key(fields: "arn") {
23
id: String! @id @search(by: [hash])
34
arn: String! @id @search(by: [hash, regexp])

0 commit comments

Comments
 (0)