Skip to content

Barman Plugin: Conditionally create self-signed Issuer based on certificate settings #749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rezaxd wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −0
Open

Barman Plugin: Conditionally create self-signed Issuer based on certificate settings #749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
365d6c4
feat(plugin-barman-cloud): create selfsigned-issuer when create[Serve…
rezaxd Dec 11, 2025
9e414a3
Fix deployment.yaml
rezaxd Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/plugin-barman-cloud/templates/certificate-issuer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
#
# SPDX-License-Identifier: Apache-2.0
#
{{- if or .Values.certificate.createClientCertificate .Values.certificate.createServerCertificate }}
---
apiVersion: cert-manager.io/v1
kind: Issuer
Expand All @@ -24,3 +25,4 @@ metadata:
namespace: {{ include "plugin-barman-cloud.namespace" . }}
spec:
selfSigned: {}
{{- end }}
12 changes: 12 additions & 0 deletions charts/plugin-barman-cloud/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,17 @@ spec:
{{- toYaml .Values.resources | nindent 10 }}
securityContext:
{{- toYaml .Values.containerSecurityContext | nindent 10 }}
{{- if or .Values.certificate.createClientCertificate .Values.certificate.createServerCertificate }}
volumeMounts:
{{- if .Values.certificate.createServerCertificate }}
- mountPath: /server
name: server
{{- end }}
{{- if .Values.certificate.createClientCertificate }}
- mountPath: /client
name: client
{{- end }}
{{- end }}
Comment on lines +82 to +92
Copy link

@ianroberts ianroberts Dec 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin still requires certificates for mTLS even if you disable the cert-manager generation in the chart. The way things are set up now in the chart, if you don't want to use cert-manager you would have to manually provision the secrets barman-cloud-client-tls and barman-cloud-server-tls with the correct certificates through some other mechanism, I guess it might make sense to allow these secret names to be overridden via chart values rather than requiring these hard-coded names.

{{- if .Values.priorityClassName }}
priorityClassName: {{ .Values.priorityClassName }}
{{- end }}
Expand All @@ -106,10 +112,16 @@ spec:
tolerations:
{{- toYaml . | nindent 8 }}
{{- end }}
{{- if or .Values.certificate.createClientCertificate .Values.certificate.createServerCertificate }}
volumes:
{{- if .Values.certificate.createServerCertificate }}
- name: server
secret:
secretName: barman-cloud-server-tls
{{- end }}
{{- if .Values.certificate.createClientCertificate }}
- name: client
secret:
secretName: barman-cloud-client-tls
{{- end }}
{{- end }}