fix: Use c-ares dns over evdns #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hao-tk
requested review from
NiccoloFei,
fcanovai,
gbartolini,
jbattiato,
litaocdl,
mnencia and
sxd
as code owners
hao-tk
force-pushed
the
hao/use-c-ares-pgbouncer-image
branch
3 times, most recently
from
df8dd9f to
85bae79
Compare
Signed-off-by: Hao Su <hao@turnkey.io>
hao-tk
force-pushed
the
hao/use-c-ares-pgbouncer-image
branch
from
85bae79 to
2e8b13c
Compare
| @@ -23,7 +23,7 @@ ARG PGBOUNCER_VERSION | |||
| # Install build dependencies. | |||
| RUN set -ex; \ | |||
| apt-get update && apt-get upgrade -y; \ | |||
| apt-get install -y --no-install-recommends curl make pkg-config libevent-dev build-essential libssl-dev libudns-dev openssl ; \ | |||
| apt-get install -y --no-install-recommends curl make pkg-config libevent-dev build-essential libssl-dev libudns-dev libc-ares2 libc-ares-dev openssl ; \ | |||
There was a problem hiding this comment.
Would we be able to remove libudns-dev from the list now that --with-udns is removed below?
| @@ -50,7 +50,7 @@ LABEL name="PgBouncer Container Images" \ | |||
|
|
|||
| RUN set -ex; \ | |||
| apt-get update && apt-get upgrade -y; \ | |||
| apt-get install -y libevent-dev libssl-dev libudns-dev libvshadow-utils findutils; \ | |||
| apt-get install -y libevent-dev libssl-dev libudns-dev libvshadow-utils findutils libc-ares2 libc-ares-dev; \ | |||
There was a problem hiding this comment.
I assume you wouldn't want the -dev package in the final image?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've seen logs pointing to dns issues after restarting control plane instances. Seeing these logs on existing pgbouncer instances on new connections created after the control plane restart. We're connecting to RDS within the same region. Seems like others are having similar issues: pgbouncer/pgbouncer#1119