Skip to content

Conversation

@Pixselve
Copy link
Contributor

Description

Export CoreSeriesMarker under internal-do-not-use.

How has this been tested?

Locally, I was able to consume CoreSeriesMarker using:

import CoreSeriesMarker from '@amzn/awsui-chart-components-console/internal-do-not-use/core-series-marker';
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Pixselve Pixselve requested a review from a team as a code owner January 12, 2026 09:03
@Pixselve Pixselve requested review from amanabiy and removed request for a team January 12, 2026 09:03
pan-kot
pan-kot previously approved these changes Jan 12, 2026
return <ChartSeriesMarker {...props} {...baseComponentProps} />;
}

applyDisplayName(CoreSeriesMarker, "CoreSeriesMarker");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't the name passed to useBaseComponent and that for applyDisplayName match?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a mistake in the core chart then. The name should match. Let's use CoreSeriesMarker here and CoreChart for the chart.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants