-
Notifications
You must be signed in to change notification settings - Fork 12
chore: export CoreSeriesMarker #148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| return <ChartSeriesMarker {...props} {...baseComponentProps} />; | ||
| } | ||
|
|
||
| applyDisplayName(CoreSeriesMarker, "CoreSeriesMarker"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the name passed to useBaseComponent and that for applyDisplayName match?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, that is not the case with CoreChart. See https://github.com/cloudscape-design/chart-components/blob/main/src/internal-do-not-use/core-chart/index.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a mistake in the core chart then. The name should match. Let's use CoreSeriesMarker here and CoreChart for the chart.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated 👍
Description
Export
CoreSeriesMarkerunderinternal-do-not-use.How has this been tested?
Locally, I was able to consume
CoreSeriesMarkerusing:Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.