Remove NSSP retired signals #2149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aysim319
approved these changes
Jun 3, 2025
Contributor
|
@aysim319 thanks for the approval, but this isnt yet passing all the tests |
Contributor
Yeah...I did notice the tests failing but since the changes are just removing the sircomplainalot alerts, I thought I would approve it for now, then was going to ping you about it, but slipped through the cracks. Weird that nssp test failed for this pr and not the pr that actually removed the stopped signals |
Contributor
Author
|
ye let me check on the tests. |
melange396
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove retired signals
pct_ed_visits_combinedandsmoothed_pct_ed_visits_combinedfrom nssp indicator run.Changelog
Remove the two signals from constants.py
Associated Issue(s)