Skip to content

Conversation

@aysim319
Copy link
Contributor

Description

update update timestamp key value from rowsUpdatedAt to viewLastModified to reflect the changes from cdc data metadata api response

Associated Issue(s)

@aysim319 aysim319 requested review from melange396, minhkhul and nolangormley and removed request for melange396 June 25, 2025 16:31
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also change:

mock_get_metadata.return_value = {"rowsUpdatedAt": time.time()}

@melange396
Copy link
Contributor

and:

mock_client.get_metadata.return_value = {"rowsUpdatedAt": now}

@aysim319 aysim319 requested a review from melange396 June 25, 2025 16:43
@aysim319 aysim319 merged commit df4d1dd into main Jun 25, 2025
15 of 17 checks passed
@aysim319 aysim319 deleted the 2152-fix_check_updates_nhsn branch June 25, 2025 16:46
@melange396 melange396 linked an issue Jun 25, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

update checking updates for nhsn

4 participants