Skip to content

Conversation

@nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Nov 6, 2025

Summary:

Context

Imputed NY state data was not available because imputation failed on issue 2023w50. Of all states, only PR was reported for that issue, which caused an error to be raised. It isn't a bug -- the imputation code was set up to fail when the system (set of states) was all-missing, none-missing, or underdetermined (too many missing states to impute). Because the data is truly missing, we can't fix the root cause of the error or similar errors.

Instead, switch the errors to informational messages, but let imputation continue.

The imputation script should automatically fill all historical dates, so we won't need to patch this manually.

Closes #1388

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@nmdefries nmdefries requested a review from dshemetov November 6, 2025 17:32
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 6, 2025

@nmdefries nmdefries merged commit 7044056 into dev Nov 6, 2025
8 checks passed
@nmdefries nmdefries deleted the ndefries/fluview-imputation-patch branch November 6, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some NY data missing from fluview

3 participants