Skip to content
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/acquisition/fluview/impute_missing_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,16 @@
# third party
import mysql.connector
import numpy as np
from warnings import warn

# first party
import delphi.operations.secrets as secrets
from delphi.utils.epiweek import delta_epiweeks
from delphi.utils.geo.locations import Locations


UNDERDETERMINED_MSG = "system is underdetermined"

class Database:
"""Database wrapper and abstraction layer."""

Expand Down Expand Up @@ -240,7 +243,7 @@ def get_fusion_parameters(known_locations):
H = graph[is_known, :]
W = graph[is_unknown, :]
if np.linalg.matrix_rank(H) != len(atoms):
raise StatespaceException("system is underdetermined")
raise StatespaceException(UNDERDETERMINED_MSG)

HtH = np.dot(H.T, H)
HtH_inv = np.linalg.inv(HtH)
Expand Down Expand Up @@ -293,7 +296,15 @@ def impute_missing_values(database, test_mode=False):
known_values["pr"] = (0, 0, 0)

# get the imputation matrix and lists of known and unknown locations
F, known, unknown = get_fusion_parameters(known_values.keys())
try:
F, known, unknown = get_fusion_parameters(known_values.keys())
except StatespaceException as e:
message = str(e)
if message == UNDERDETERMINED_MSG:
warn(message)
else:
print(message)
continue

# finally, impute the missing values
z = np.array([known_values[k] for k in known])
Expand Down
5 changes: 2 additions & 3 deletions tests/acquisition/fluview/test_impute_missing_values.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
get_argument_parser,
get_lag_and_ili,
impute_missing_values,
StatespaceException,
)

# py3tester coverage target
Expand Down Expand Up @@ -87,7 +86,7 @@ def test_impute_missing_values_vipr(self):
db.get_known_values.return_value = known_data

db.find_missing_rows.return_value = [(201340, 201340)]
with self.assertRaises(Exception):
with self.assertWarns(Warning):
impute_missing_values(db, test_mode=True)

db.find_missing_rows.return_value = [(201339, 201339)]
Expand Down Expand Up @@ -131,5 +130,5 @@ def test_impute_missing_values_underdetermined(self):
db.find_missing_rows.return_value = [(201740, 201740)]
db.get_known_values.return_value = known_data

with self.assertRaises(StatespaceException):
with self.assertWarns(Warning):
impute_missing_values(db, test_mode=True)