Use GraphQL for GitHub - 2 #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
li-boxuan
reviewed
Jun 30, 2018
app/graphql/github.js
Outdated
| if (!orgs) { | ||
| warn('Org is not defined.'); | ||
| } | ||
| if (orgs) { |
app/helpers/truncate-text.js
Outdated
| const { limit } = hash; | ||
| let text = ''; | ||
|
|
||
| if (value != null && value.length > 0) { |
There was a problem hiding this comment.
I personally prefer if (value && value.length), but it's up to you.
| try { | ||
| return JSON.parse(value); | ||
| } catch (e) { | ||
| return {}; |
There was a problem hiding this comment.
What about logging the exception here?
bekicot
force-pushed
the
use-graphql-2
branch
2 times, most recently
from
54ed938 to
3c65035
Compare
Use GraphQL for GitHub API Add support to coala & 52North Add GitHub token modal Rename implementation of Issues to Tasks Use Bulma for task list Regression: Remove Repository and User Model Remove Search Bar Closes coala#34
blazeu
approved these changes
Jul 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use GraphQL for GitHub API
Add support to coala & 52North
Add GitHub token modal
Rename implementation of Issues to Tasks
Use Bulma for task list
Regression:
Remove Repository and User Model
Remove Search Bar
Closes #34
Old PR #33