mma: fix todos related to is-leaseholder assertions #158277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing assertions were valid, but needed better commentary. Also added a new assertion. Epic: CRDB-55052 Release note: None
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
wenyihu6
approved these changes
Nov 24, 2025
Contributor
wenyihu6
left a comment
wenyihu6
left a comment
There was a problem hiding this comment.
TestReplicateQueueRebalanceMultiStore unrelated flake.
bors r+
Contributor
|
Build succeeded: |
sumeerbhola
commented
Nov 25, 2025
Collaborator
Author
sumeerbhola
left a comment
sumeerbhola
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/kv/kvserver/allocator/mmaprototype/cluster_state_rebalance_stores.go line 532 at r1 (raw file):
// below. The code below additionally ignores the range if it has pending // changes, which while not necessary for the is-leaseholder assertion, // makes the case where we assert even narrower.
I forgot to remove this. Will send a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing assertions were valid, but needed better commentary. Also added a new assertion.
Epic: CRDB-55052
Release note: None