Skip to content

Conversation

@pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Nov 24, 2025

This PR makes tests using testContext aware of the separated engines.

Part of #97627

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv force-pushed the assert-state-two-engines branch from 47b08e5 to 2c91ede Compare November 24, 2025 17:16
@pav-kv pav-kv marked this pull request as ready for review November 24, 2025 17:16
@pav-kv pav-kv requested a review from a team as a code owner November 24, 2025 17:16
@pav-kv pav-kv changed the title kvserver: split state/raft engine in testContext kvserver: split state/raft engines in testContext Nov 24, 2025
Copy link
Collaborator

@arulajmani arulajmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@arulajmani reviewed 1 of 1 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 2 of 2 files at r5, 7 of 7 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @iskettaneh)

@pav-kv
Copy link
Collaborator Author

pav-kv commented Nov 25, 2025

TFTR!

bors r=arulajmani

craig bot pushed a commit that referenced this pull request Nov 25, 2025
158280: kvserver: split state/raft engines in testContext r=arulajmani a=pav-kv

This PR makes tests using `testContext` aware of the separated engines.

Part of #97627

Co-authored-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
@craig
Copy link
Contributor

craig bot commented Nov 25, 2025

Build failed:

@pav-kv
Copy link
Collaborator Author

pav-kv commented Nov 25, 2025

bors retry

@craig
Copy link
Contributor

craig bot commented Nov 25, 2025

@craig craig bot merged commit b2158da into cockroachdb:master Nov 25, 2025
26 of 27 checks passed
@pav-kv pav-kv deleted the assert-state-two-engines branch November 25, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants