Skip to content

Conversation

@edcodedotorg
Copy link
Contributor

This PR fixes a bug that occured when copyable code overflows its container. In this case, the overlay, that indicates the code was successfully copied, was scrolling with the content and no longer covering the content. The fix makes the overlay stay in place so that the text "Copied" is always centered and the overlay fully covers the copied code as intended.

Before (AI Tutor):

background-bug.mov

After (AI Tutor):

Screen.Recording.2025-11-05.at.12.28.58.PM.mov

After (AI Chat):

Screen.Recording.2025-11-05.at.12.34.28.PM.mov

Links

This was mentioned in slack here and the Jira ticket is here.

Testing story

The fix was manually tested in both AI tutor and AI Chat.

PR Creation Checklist:

  • Tests provide adequate coverage
  • Privacy impacts have been documented
  • Security impacts have been documented
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Follow-up work items (including potential tech debt) are tracked and linked

border: none;
background-color: var(--background-neutral-primary);
color: var(--text-neutral-primary);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick, it looks like the indentation is off here. do you have prettier set up to auto fix on save?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope I've been relying on our linter rules which apparently aren't set for css/scss?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation should be fixed, thanks!

@MollyPeredo
Copy link

Visuals look good. Thanks for catching and fixing this!

Copy link
Contributor

@cnbrenci cnbrenci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@edcodedotorg edcodedotorg merged commit 00b74cd into staging Nov 7, 2025
6 checks passed
@edcodedotorg edcodedotorg deleted the ed/aitutor-fix-overlay-scroll-bug branch November 7, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants