Skip to content

Conversation

code-inflation
Copy link
Owner

…ilds

@code-inflation code-inflation force-pushed the feature/faster-docker-arm-builds branch from e0867ec to bd19161 Compare April 4, 2025 22:02
@code-inflation code-inflation requested a review from Copilot April 4, 2025 22:20
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • Dockerfile: Language not supported

@code-inflation code-inflation requested a review from Copilot April 4, 2025 22:30
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Dockerfile: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/CI.yml:52

  • [nitpick] The tagging in the CI workflow uses '${{ github.sha }}' while the release workflow uses '${{ github.ref_name }}'. Consider unifying the docker image tag format across workflows for consistency.
cybuerg/cfspeedtest:${{ github.sha }}-amd64

.github/workflows/CI.yml:106

  • The grep pattern 'x86-64' in the verification step might be fragile if the output uses 'x86_64'. Verify the expected output of the 'file' command and adjust the pattern accordingly.
docker run --entrypoint /bin/sh cybuerg/cfspeedtest:${{ github.sha }}-amd64 -c "file /usr/local/bin/cfspeedtest" | grep "x86-64"

@code-inflation code-inflation requested a review from Copilot April 4, 2025 22:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • Dockerfile: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/release.yaml:103

  • Both build steps for amd64 and arm64 use the same cache-from source before merging updated caches. Consider separating cache restoration or merging caches earlier so that each build step benefits from the latest cache updates.
cp -r /tmp/.buildx-cache-amd64/* /tmp/.buildx-cache-new/ || true

.github/workflows/CI.yml:71

  • Similar to the release workflow, the CI build uses a common cache restoration source before merging new cache outputs. Consider ensuring each architecture build independently accesses an up-to-date cache to improve build efficiency.
cp -r /tmp/.buildx-cache-arm64/* /tmp/.buildx-cache-new/ || true

@code-inflation code-inflation merged commit bf0d100 into master Apr 9, 2025
7 checks passed
@code-inflation code-inflation deleted the feature/faster-docker-arm-builds branch April 9, 2025 17:17
code-inflation added a commit that referenced this pull request Jul 31, 2025
…-builds

feat: Implement cross-compilation and Docker layer caching for ARM bu…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant