Inbox mail table #362
Open
Inbox mail table #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lumburovskalina
commented
Nov 26, 2025
| daemon.run_with_db_token(__migrate_kratos_users) | ||
|
|
||
|
|
||
| def __migrate_kratos_users(): |
Contributor
Author
There was a problem hiding this comment.
why do we have two functions __migrate_kratos_users ?
remove the old one if not used?
lumburovskalina
commented
Nov 26, 2025
| def get_inbox_mails_by_thread( | ||
| org_id: str, | ||
| user_id: str, | ||
| thread_id: Optional[str] = None, |
Contributor
Author
There was a problem hiding this comment.
optional as the last param
lumburovskalina
commented
Nov 26, 2025
| def get_all_users( | ||
| organization_id: str, user_role: Optional[str] = None, as_dict: bool = True | ||
| organization_id: str, | ||
| user_role: Optional[str] = None, |
Contributor
Author
There was a problem hiding this comment.
optional at the end
lumburovskalina
commented
Nov 26, 2025
| return {str(u.id): u.role for u in user.get_all()} | ||
|
|
||
|
|
||
| def get_admin_users(expand_mail_name: bool = False) -> List[User]: |
Contributor
Author
There was a problem hiding this comment.
this two functions look similar only the call is different not sure if it makes sense to be one function with a parameter?
lumburovskalina
commented
Nov 26, 2025
| raise HTTPException(status_code=403, detail="Not authorized") | ||
|
|
||
| mail = inbox_mail_manager.create_inbox_mail_by_thread( | ||
| org_id=user.organization_id, |
Contributor
Author
There was a problem hiding this comment.
shouldn't the organization come from the FE? I think it's not the org of the user but the org that was selected in the modal?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.