Skip to content
Draft
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
774f167
feat(4422): Use Maven v3.9.10 via Maven Wrapper v3.3.2
Jul 1, 2025
c148505
feat(4422): Set enforcer to require Maven v3.9
Jul 1, 2025
a57683f
feat(4422): Do not use spring release repository. See: https://spring…
Jul 1, 2025
a4f6eb3
feat(4422): Switch from com.github.tomakehurst:wiremock-jre8-standalo…
Jul 1, 2025
2f26583
feat(4422): Use https
Jul 1, 2025
242ad5d
feat(4422): Clean up reactor pom
Jul 2, 2025
c8e12e4
feat(4422): Clean up reactor pom
Jul 2, 2025
412a2d9
feat(4422): Clean up modules poms
Jul 2, 2025
75bcda9
feat(4422): Update autogenerated frontend artifacts
Jul 2, 2025
40eeab6
feat(4422): Use Maven v4.0.0-rc-4 via Maven Wrapper v3.3.2
Jul 3, 2025
e86beb8
feat(4422): Set enforcer to require Maven v4.0.0-rc-4 or newer
Jul 3, 2025
da01ab7
feat(4422): Clean up code
Jul 3, 2025
8b22c79
feat(4422): Use Maven Wrapper in workflows
Jul 3, 2025
b1af53b
feat(4422): Replace deprecated ${basedir} with ${project.basedir}
Jul 3, 2025
e85f7ff
feat(4422): Clean up modules poms
Jul 3, 2025
22397a9
feat(4422): Clean up modules poms
Jul 3, 2025
a5e7531
feat(4422): Fix OpenJDK 64-Bit Server VM "sharing" warning
Jul 3, 2025
7bd202c
feat(4422): Maven 4 related fixes
Jul 4, 2025
a1151f0
feat(4422): Clean up modules poms
Jul 4, 2025
cc420d6
feat(4422): Clean up reactor pom
Jul 4, 2025
db03b57
Merge remote-tracking branch 'origin/master' into feat/migrate-to-mav…
Jul 7, 2025
5176c43
feat(4422): Clean up modules poms
Jul 7, 2025
386332c
feat(4422): Maven 4 related fixes: fix copy-resources
Jul 7, 2025
30831ef
feat(4422): Clean up reactor pom
Jul 7, 2025
2523a36
feat(4422): Maven 4 related fixes: fix copy-resources
Jul 7, 2025
ab1066a
feat(4422): Clean up modules poms
Jul 8, 2025
37cbda8
feat(4422): Clean up reactor pom
Jul 8, 2025
41be664
feat(4422): Clean up modules poms
Jul 8, 2025
66af1dc
feat(4422): Clean up reactor pom
Jul 8, 2025
1c298a2
Merge remote-tracking branch 'origin/master' into feat/migrate-to-mav…
Jul 10, 2025
546596b
feat(4422): Clean up
Jul 10, 2025
e902124
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 10, 2025
e368d1e
Merge remote-tracking branch 'origin/master' into feat/migrate-to-mav…
Jul 11, 2025
33e5965
Merge remote-tracking branch 'origin/master' into feat/migrate-to-mav…
Jul 16, 2025
07984b8
feat(4455): Clean up parent pom path
Jul 16, 2025
fad46fc
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 17, 2025
b2e691b
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 18, 2025
075d3fe
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 21, 2025
1c563e7
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 23, 2025
465fb46
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 25, 2025
4db8859
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 28, 2025
4c9e48e
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Jul 28, 2025
b5460ee
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Aug 4, 2025
7e0f62d
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Aug 6, 2025
960cfaf
Merge branch 'master' into feat/migrate-to-maven-4-part-2
mirogaudi Aug 7, 2025
b500a3e
Merge branch 'master' into feat/migrate-to-maven-4-part-2
SteKoe Sep 5, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Extract Maven project version for Asciidoc GitHub Pages directory naming
run: echo ::set-output name=version::$(mvn -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec)
run: echo ::set-output name=version::$(./mvnw -q -Dexec.executable=echo -Dexec.args='${project.version}' --non-recursive exec:exec)
id: project

- name: Show extracted Maven project version
Expand Down
2 changes: 1 addition & 1 deletion .mvn/wrapper/maven-wrapper.properties
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,4 @@
# under the License.
wrapperVersion=3.3.2
distributionType=only-script
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/3.9.10/apache-maven-3.9.10-bin.zip
distributionUrl=https://repo.maven.apache.org/maven2/org/apache/maven/apache-maven/4.0.0-rc-4/apache-maven-4.0.0-rc-4-bin.zip
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ You can find some hints for starting development in the [README](spring-boot-adm
### Java / Server
We try to satisfy the [Code Style of Spring Framework](https://github.com/spring-projects/spring-framework/wiki/Code-Style).

The [Spring Java Format Plugin](https://github.com/spring-io/spring-javaformat) is added to the build. Checkstyle will enforce the consistency of the code. Nevertheless there are some disabled rules, due to backward compatibility. You can find these disabled rules in a comment in `src/checkstyle/checkstyle.xml`.
The [Spring Java Format Plugin](https://github.com/spring-io/spring-javaformat) is added to the build. Checkstyle will enforce the consistency of the code. Nevertheless, there are some disabled rules, due to backward compatibility. You can find these disabled rules in a comment in `src/checkstyle/checkstyle.xml`.

However, you can always run `mvn spring-javaformat:apply` to fix some basic errors, like indentation.
However, you can always run `./mvnw spring-javaformat:apply` to fix some basic errors, like indentation.

### JavaScript / Client
The Vue frontend implements basic prettier rules as well as Vue3 recommended rules.
Expand All @@ -21,7 +21,7 @@ Append `:fix` to let eslint or prettier auto-solve most issues.
The IntelliJ settings are based on the IntelliJ-IDEA-Editor-Settings from spring, but have been adapted slightly, you can find the original settings [here](https://github.com/spring-projects/spring-framework/wiki/IntelliJ-IDEA-Editor-Settings).
The custom settings are stored in `.editorconfig` and are imported automatically by IntelliJ.
If you are using IntelliJ, there is also a [formatter-plugin provided by Spring](https://github.com/spring-io/spring-javaformat#intellij-idea).
(i) Plugin version x didn't not work in IntelliJ IDEA Ultimate 2020.3.
(i) Plugin version x did not work in IntelliJ IDEA Ultimate 2020.3.

#### Checkstyle Plugin
This plugin scans Java files with the project's custom CheckStyle rules from within IDEA.
Expand Down
23 changes: 16 additions & 7 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,22 +35,26 @@
<java.version>17</java.version>
<node.version>v22.12.0</node.version>

<require.maven.version>[4.0.0-rc-4,)</require.maven.version>

<maven.compiler.source>${java.version}</maven.compiler.source>
<maven.compiler.target>${java.version}</maven.compiler.target>
<resource.delimiter>@</resource.delimiter>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>

<!-- required for later replacement of argLine -->
<argLine/>

<!-- used dependencies versions -->
<spring-boot.version>3.5.3</spring-boot.version>
<spring-cloud.version>2025.0.0</spring-cloud.version>
<jolokia-support-spring.version>2.2.9</jolokia-support-spring.version>

<checkstyle.version>10.26.1</checkstyle.version>
<findbugs-jsr305.version>3.0.2</findbugs-jsr305.version>

<wiremock.version>3.13.1</wiremock.version>
<hazelcast-tests.version>5.5.0</hazelcast-tests.version>
<hazelcast.version>5.5.0</hazelcast.version>
<awaitility.version>4.3.0</awaitility.version>
<testcontainers.version>1.21.3</testcontainers.version>
<jetty.version>12.0.23</jetty.version>
Expand All @@ -72,7 +76,6 @@
<maven-javadoc-plugin.version>3.11.2</maven-javadoc-plugin.version>
<maven-resources-plugin.version>3.3.1</maven-resources-plugin.version>
<maven-source-plugin.version>3.3.1</maven-source-plugin.version>
<maven-war-plugin.version>3.4.0</maven-war-plugin.version>
<maven-gpg-plugin.version>3.2.8</maven-gpg-plugin.version>
<frontend-maven-plugin.version>1.15.1</frontend-maven-plugin.version>
<jacoco-maven-plugin.version>0.8.13</jacoco-maven-plugin.version>
Expand All @@ -81,15 +84,16 @@
<maven-checkstyle-plugin.version>3.6.0</maven-checkstyle-plugin.version>
<spring-javaformat-maven-plugin.version>0.0.47</spring-javaformat-maven-plugin.version>
<central-publishing-maven-plugin.version>0.8.0</central-publishing-maven-plugin.version>
<spring-conf-prop-documenter-maven-plugin.version>0.7.1</spring-conf-prop-documenter-maven-plugin.version>
</properties>

<modules>
<module>spring-boot-admin-dependencies</module>
<module>spring-boot-admin-build</module>
<module>spring-boot-admin-server</module>
<module>spring-boot-admin-server-ui</module>
<module>spring-boot-admin-client</module>
<module>spring-boot-admin-dependencies</module>
<module>spring-boot-admin-docs</module>
<module>spring-boot-admin-build</module>
<module>spring-boot-admin-starter-server</module>
<module>spring-boot-admin-starter-client</module>
<module>spring-boot-admin-samples</module>
Expand Down Expand Up @@ -223,7 +227,7 @@
<configuration>
<rules>
<requireMavenVersion>
<version>3.9</version>
<version>${require.maven.version}</version>
</requireMavenVersion>
</rules>
</configuration>
Expand Down Expand Up @@ -332,7 +336,7 @@
<version>${maven-surefire-plugin.version}</version>
<configuration>
<redirectTestOutputToFile>true</redirectTestOutputToFile>
<rerunFailingTestsCount>2</rerunFailingTestsCount>
<argLine>@{argLine} -Xshare:off</argLine>
<includes>
<include>**/*Tests.java</include>
<include>**/*Test.java</include>
Expand Down Expand Up @@ -395,6 +399,11 @@
<artifactId>central-publishing-maven-plugin</artifactId>
<version>${central-publishing-maven-plugin.version}</version>
</plugin>
<plugin>
<groupId>org.rodnansol</groupId>
<artifactId>spring-configuration-property-documenter-maven-plugin</artifactId>
<version>${spring-conf-prop-documenter-maven-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down
18 changes: 16 additions & 2 deletions spring-boot-admin-build/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
<dependency>
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-dependencies</artifactId>
<version>${spring-boot.version}</version>
<version>3.5.3</version> <!-- hardcoded to fix issues with sbom, should be ${spring-boot.version} -->
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -50,7 +50,7 @@
<dependency>
<groupId>com.hazelcast</groupId>
<artifactId>hazelcast</artifactId>
<version>${hazelcast-tests.version}</version>
<version>${hazelcast.version}</version>
<classifier>tests</classifier>
</dependency>
<dependency>
Expand All @@ -59,6 +59,12 @@
<version>${findbugs-jsr305.version}</version>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-alpn-server</artifactId>
<version>${jetty.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.awaitility</groupId>
<artifactId>awaitility</artifactId>
Expand All @@ -77,6 +83,14 @@
<version>${testcontainers.version}</version>
<scope>test</scope>
</dependency>

<!-- Maven 4 related fixes: delete as soon as not needed! -->
<dependency>
<groupId>org.springframework.retry</groupId>
<artifactId>spring-retry</artifactId>
<version>2.0.12</version>
</dependency>

</dependencies>
</dependencyManagement>

Expand Down
1 change: 0 additions & 1 deletion spring-boot-admin-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
<dependency>
<groupId>org.wiremock</groupId>
<artifactId>wiremock-standalone</artifactId>
<version>${wiremock.version}</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
1 change: 0 additions & 1 deletion spring-boot-admin-docs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@
<plugin>
<groupId>org.rodnansol</groupId>
<artifactId>spring-configuration-property-documenter-maven-plugin</artifactId>
<version>0.7.1</version>
<executions>
<execution>
<id>generate-adoc</id>
Expand Down
25 changes: 21 additions & 4 deletions spring-boot-admin-samples/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,19 +34,26 @@
</parent>

<modules>
<module>spring-boot-admin-sample-custom-ui</module>
<module>spring-boot-admin-sample-servlet</module>
<module>spring-boot-admin-sample-reactive</module>
<module>spring-boot-admin-sample-war</module>
<module>spring-boot-admin-sample-hazelcast</module>
<module>spring-boot-admin-sample-custom-ui</module>
</modules>

<properties>
<jolokia-support-spring.version>2.2.9</jolokia-support-spring.version>

<maven-war-plugin.version>3.4.0</maven-war-plugin.version>
<cyclonedx-maven-plugin.version>2.9.1</cyclonedx-maven-plugin.version>
</properties>

<dependencyManagement>
<dependencies>
<dependency>
<groupId>org.springframework.cloud</groupId>
<artifactId>spring-cloud-dependencies</artifactId>
<version>${spring-cloud.version}</version>
<version>2025.0.0</version> <!-- hardcoded to fix issues with sbom, should be ${spring-cloud.version} -->
<type>pom</type>
<scope>import</scope>
</dependency>
Expand All @@ -55,14 +62,19 @@
<artifactId>spring-boot-admin-sample-custom-ui</artifactId>
<version>${revision}</version>
</dependency>
<dependency>
<groupId>org.jolokia</groupId>
<artifactId>jolokia-support-spring</artifactId>
<version>${jolokia-support-spring.version}</version>
</dependency>
</dependencies>
</dependencyManagement>

<build>
<!-- Turn on filtering by default for application properties -->
<resources>
<resource>
<directory>${basedir}/src/main/resources</directory>
<directory>${project.basedir}/src/main/resources</directory>
<filtering>true</filtering>
<includes>
<include>**/application*.yml</include>
Expand All @@ -71,7 +83,7 @@
</includes>
</resource>
<resource>
<directory>${basedir}/src/main/resources</directory>
<directory>${project.basedir}/src/main/resources</directory>
<excludes>
<exclude>**/application*.yml</exclude>
<exclude>**/application*.yaml</exclude>
Expand Down Expand Up @@ -99,6 +111,11 @@
<artifactId>spring-boot-maven-plugin</artifactId>
<version>${spring-boot.version}</version>
</plugin>
<plugin>
<groupId>org.cyclonedx</groupId>
<artifactId>cyclonedx-maven-plugin</artifactId>
<version>${cyclonedx-maven-plugin.version}</version>
</plugin>
</plugins>
</pluginManagement>
</build>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,27 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-resources-plugin</artifactId>
<executions>
<execution>
<id>copy-resources</id>
<phase>process-resources</phase>
<goals>
<goal>copy-resources</goal>
</goals>
<configuration>
<outputDirectory>
${project.build.outputDirectory}/META-INF/spring-boot-admin-server-ui/extensions/custom
</outputDirectory>
<resources>
<resource>
<directory>${project.build.directory}/dist</directory>
<filtering>false</filtering>
</resource>
</resources>
</configuration>
</execution>
</executions>
</plugin>
</plugins>

<resources>
<resource>
<directory>target/dist</directory>
<targetPath>META-INF/spring-boot-admin-server-ui/extensions/custom</targetPath>
<filtering>false</filtering>
</resource>
</resources>
</build>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
</parent>

<properties>
<zstd-jni.version>1.5.7-4</zstd-jni.version>
<native-build-tools-plugin.version>0.10.6</native-build-tools-plugin.version>
<maven.javadoc.skip>true</maven.javadoc.skip>
</properties>
Expand All @@ -53,7 +54,7 @@
<dependency>
<groupId>com.github.luben</groupId>
<artifactId>zstd-jni</artifactId>
<version>1.5.7-4</version>
<version>${zstd-jni.version}</version>
</dependency>
<dependency>
<groupId>io.netty</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
<dependency>
<groupId>org.jolokia</groupId>
<artifactId>jolokia-support-spring</artifactId>
<version>${jolokia-support-spring.version}</version>
</dependency>
<!-- Test -->
<dependency>
Expand All @@ -95,19 +94,21 @@
<plugin>
<groupId>org.cyclonedx</groupId>
<artifactId>cyclonedx-maven-plugin</artifactId>
<version>2.9.1</version>
<executions>
<execution>
<phase>validate</phase>
<phase>generate-resources</phase>
<goals>
<goal>makeAggregateBom</goal>
</goals>
<configuration>
<projectType>application</projectType>
<outputDirectory>${project.build.outputDirectory}</outputDirectory>
<outputName>bom</outputName>
<outputFormat>json</outputFormat>
<skipAttach>true</skipAttach>
</configuration>
</execution>
</executions>
<configuration>
<outputFormat>json</outputFormat>
<outputName>classes/bom</outputName>
</configuration>
</plugin>
<plugin>
<groupId>org.springframework.boot</groupId>
Expand Down
Loading
Loading