Skip to content

Conversation

@seer-by-sentry
Copy link
Contributor

@seer-by-sentry seer-by-sentry bot commented Dec 9, 2025

Fixes WORKER-TCA. The issue was that: Before update trigger recursively modified the same row because the exclusion condition was not active on the worker's database connection.

  • Converted PostgreSQL triggers on the owners table from BEFORE to AFTER timing (e.g., owners_before_insert is now owners_after_insert).
  • This change resolves potential database errors (TriggeredDataChangeViolation) caused by BEFORE triggers attempting to modify the table they are triggered on.
  • Applied the fix via migration 0011_convert_owners_trigger_to_after.py and updated the source SQL definition.

This fix was generated by Seer in Sentry, triggered by Tom Hu. 👁️ Run ID: 6606469

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #607 will not alter performance

Comparing seer/fix/convert-owners-trigger-to-after (cfb3f79) with main (6f76140)1

Summary

✅ 9 untouched

Footnotes

  1. No successful run was found on main (d1ef920) during the generation of this report, so 6f76140 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@sentry
Copy link

sentry bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.87%. Comparing base (6f76140) to head (cfb3f79).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #607   +/-   ##
=======================================
  Coverage   93.87%   93.87%           
=======================================
  Files        1285     1286    +1     
  Lines       46674    46678    +4     
  Branches     1522     1522           
=======================================
+ Hits        43816    43820    +4     
  Misses       2548     2548           
  Partials      310      310           
Flag Coverage Δ
sharedintegration 38.78% <0.00%> (-0.02%) ⬇️
sharedunit 88.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants