Skip to content

Fix vertical alignment in topmost collapseUnchanged and collapseRanges bars #2911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

Fix vertical alignment in topmost collapseUnchanged and collapseRanges bars #2911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/utils/code-mirror-themes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ const BASE_STYLE = {

'& .cm-cc-collapsedLinesInner': {
borderTop: 'none',
paddingTop: '6px',
},
},

Expand Down Expand Up @@ -246,6 +247,7 @@ const BASE_STYLE = {

'& .cm-collapsedRangesInner': {
borderTop: 'none',
paddingTop: '6px',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where does this magic number come from 🤔 Any way to make this a bit more obvious?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we don't document things like 1px, 0.5 rem etc. since they directly map to Tailwind units. Anything outside common values is worth looking at - either we change to use the standard ones, or we document well

Copy link
Collaborator Author

@VasylMarchuk VasylMarchuk Jun 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sure, magic number comes from CodeMirror itself where default padding is 5px, and I am making it 6.

I was thinking myself about how to improve this, maybe use CSS variables and calc. The problem is that CodeMirror does not use Tailwind, the values are hardcoded either in default styles or in default theme (which we override), and CodeMirror is kind of it's own separate thing, a subproject inside our project. Can't wait for a chance to extract it into a separate Ember addon and repository, so it doesn't pollute ours with stuff like this.

Will see what I can do with this one.

@rohitpaulk

},
},

Expand Down
Loading