Skip to content

⚡️ Speed up function caching_module_getattr by 5% #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function caching_module_getattr by 5% #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions lib/matplotlib/_api/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,14 +206,16 @@ def name(self): ...

assert cls.__name__ == "__getattr__"
# Don't accidentally export cls dunders.
props = {name: prop for name, prop in vars(cls).items()
if isinstance(prop, property)}

# Optimize: build props only once and bind instance in closure.
props = {name: prop for name, prop in cls.__dict__.items() if isinstance(prop, property)}
instance = cls()

@functools.cache
def __getattr__(name):
if name in props:
return props[name].__get__(instance)
prop = props.get(name)
if prop is not None:
return prop.__get__(instance)
raise AttributeError(
f"module {cls.__module__!r} has no attribute {name!r}")

Expand Down