Skip to content

⚡️ Speed up function _get_pyplot_commands by 21% #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function _get_pyplot_commands by 21% #254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 21 additions & 19 deletions lib/matplotlib/pyplot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,16 +49,13 @@
import threading
import time
from typing import TYPE_CHECKING, cast, overload

from cycler import cycler # noqa: F401
import matplotlib
import matplotlib.colorbar
import matplotlib.image
from matplotlib import _api
from matplotlib import ( # noqa: F401 Re-exported for typing.
cm as cm, get_backend as get_backend, rcParams as rcParams, style as style)
cm as cm, get_backend as get_backend, rcParams as rcParams)
from matplotlib import _pylab_helpers
from matplotlib import interactive # noqa: F401
from matplotlib import cbook
from matplotlib import _docstring
from matplotlib.backend_bases import (
Expand All @@ -68,16 +65,16 @@
from matplotlib import rcsetup, rcParamsDefault, rcParamsOrig
from matplotlib.artist import Artist
from matplotlib.axes import Axes
from matplotlib.axes import Subplot # noqa: F401
from matplotlib.backends import BackendFilter, backend_registry
from matplotlib.projections import PolarAxes
from matplotlib import mlab # for detrend_none, window_hanning
from matplotlib.scale import get_scale_names # noqa: F401

from matplotlib.cm import _colormaps
from matplotlib.colors import _color_sequences, Colormap

import numpy as np
import PIL.Image
import matplotlib.backends

if TYPE_CHECKING:
from collections.abc import Callable, Hashable, Iterable, Sequence
Expand Down Expand Up @@ -129,15 +126,7 @@
from matplotlib.colors import Normalize
from matplotlib.lines import Line2D, AxLine
from matplotlib.text import Text, Annotation
from matplotlib.patches import Arrow, Circle, Rectangle # noqa: F401
from matplotlib.patches import Polygon
from matplotlib.widgets import Button, Slider, Widget # noqa: F401

from .ticker import ( # noqa: F401
TickHelper, Formatter, FixedFormatter, NullFormatter, FuncFormatter,
FormatStrFormatter, ScalarFormatter, LogFormatter, LogFormatterExponent,
LogFormatterMathtext, Locator, IndexLocator, FixedLocator, NullLocator,
LinearLocator, LogLocator, AutoLocator, MultipleLocator, MaxNLocator)

_log = logging.getLogger(__name__)

Expand Down Expand Up @@ -2386,11 +2375,24 @@ def _get_pyplot_commands() -> list[str]:
# functions, and anything marked as private with a preceding underscore.
exclude = {'colormaps', 'colors', 'get_plot_commands', *colormaps}
this_module = inspect.getmodule(get_plot_commands)
return sorted(
name for name, obj in globals().items()
if not name.startswith('_') and name not in exclude
and inspect.isfunction(obj)
and inspect.getmodule(obj) is this_module)
# Inline variable lookup and minimize attribute access in the loop
globals_items = globals().items()
startswith = str.startswith
isfunction = inspect.isfunction
getmodule = inspect.getmodule

# Building results list without calling sorted with a generator
results = []
for name, obj in globals_items:
if (
not startswith(name, '_')
and name not in exclude
and isfunction(obj)
and getmodule(obj) is this_module
):
results.append(name)
results.sort()
return results


## Plotting part 1: manually generated functions and wrappers ##
Expand Down