Skip to content

⚡️ Speed up function Error by 37% #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up function Error by 37% #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion lib/matplotlib/_mathtext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1745,7 +1745,19 @@ def Error(msg: str) -> ParserElement:
def raise_error(s: str, loc: int, toks: ParseResults) -> T.Any:
raise ParseFatalException(s, loc, msg)

return Empty().setParseAction(raise_error)
# Store Empty() as a static variable, and clone it for each call
# This avoids the cost of creating a new Empty instance each time
# but preserves the behavior of getting a fresh parser element (no side effects)
if not hasattr(Error, "_empty_with_action"):
e = Empty().setParseAction(raise_error)
Error._empty_with_action = e
Error._raise_error = raise_error
else:
e = Error._empty_with_action
raise_error = Error._raise_error

# Clone the parser element to avoid any potential mutation
return e.copy()


class ParserState:
Expand Down