Skip to content

⚡️ Speed up method Parser.is_overunder by 31% #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codeflash-ai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

⚡️ Speed up method Parser.is_overunder by 31% #262

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lib/matplotlib/_mathtext.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2426,10 +2426,15 @@ def font(self, toks: ParseResults) -> T.Any:
return []

def is_overunder(self, nucleus: Node) -> bool:
if isinstance(nucleus, Char):
return nucleus.c in self._overunder_symbols
elif isinstance(nucleus, Hlist) and hasattr(nucleus, 'function_name'):
return nucleus.function_name in self._overunder_functions
# OPTIMIZED: eliminate repeated hasattr on Hlist that are not Hlists,
# avoid double work for isinstance checks
nc = nucleus
if type(nc) is Char:
# type() check is faster and sufficient here, also avoids inheritance issues
return nc.c in self._overunder_symbols
if type(nc) is Hlist:
# Only check attribute if we're sure it's Hlist for maximal speed
return getattr(nc, 'function_name', None) in self._overunder_functions
return False

def is_dropsub(self, nucleus: Node) -> bool:
Expand Down