AvailabilityChecker: Remove hard requirement on tobii_research #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now tobii_research [1][2] module does not need to be installed to be able to use mouse emulation. [1]: https://developer.tobiipro.com/python.html [2]: https://pypi.org/project/tobii-research/ This change removes 'import tobii_research as tr' from checkPythonEnvironment() method, and adjusts checkEyeTracker() and getEyeTrackerName() to work correctly even if tobii_research is not installed. Not tested yet. The problem with requiring tobii_research is that it requires specific Python version to be able to be installed: 3.8 or 3.10 [3][4][5] [3]: https://www.tobii.com/products/software/applications-and-developer-kits/tobii-pro-sdk [4]: https://developer.tobiipro.com/tobiiprosdk/platform-and-language.html [5]: https://codegrits.github.io/CodeGRITS/usage-guide/#python-environment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of how
AvailibilityChecker.checkPythonEnvironment()was set up, thetobii_researchmodule had to be installed in the selected Python environment even when one wanted to use Mouse emulation.Installing
tobii_researchis more difficult than installingpyautoguibecausetobii_researchrequires specific Python version, namely Python 3.10 (or Python 3.8, but with more work). Switching to non-default version of Python is more work.I have tested that mouse emulation work with these changes, but I was not able to check if tracking with Tobii still works.
Now
tobii_researchmodule does not need to be installed to be able to use mouse emulation.This change removes 'import tobii_research as tr' from checkPythonEnvironment() method, and adjusts checkEyeTracker() and getEyeTrackerName() to work correctly even if tobii_research is not installed.
The problem with requiring tobii_research is that it requires specific Python version to be able to be installed: 3.8 or 3.10: