Merge pull request #1256 from codeigniter4/refactor-by-addSeconds

datamweb · web-flow · commit 57d5d5c40e2e · 2025-02-28T10:40:44.000+03:30
refactor: improve expiration time calculation using `addSeconds()`
diff --git a/src/Authentication/Authenticators/Session.php b/src/Authentication/Authenticators/Session.php
@@ -927,9 +927,9 @@ protected function rememberUser(User $user): void
 
     private function calcExpires(): Time
     {
-        $timestamp = Time::now()->getTimestamp() + setting('Auth.sessionConfig')['rememberLength'];
+        $rememberLength = setting('Auth.sessionConfig')['rememberLength'];
 
-        return Time::createFromTimestamp($timestamp);
+        return Time::now()->addSeconds($rememberLength);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -927,9 +927,9 @@ protected function rememberUser(User $user): void`
`927`	`927`
`928`	`928`	`private function calcExpires(): Time`
`929`	`929`	`{`
`930`		`- $timestamp = Time::now()->getTimestamp() + setting('Auth.sessionConfig')['rememberLength'];`
	`930`	`+ $rememberLength = setting('Auth.sessionConfig')['rememberLength'];`
`931`	`931`
`932`		`- return Time::createFromTimestamp($timestamp);`
	`932`	`+ return Time::now()->addSeconds($rememberLength);`
`933`	`933`	`}`
`934`	`934`
`935`	`935`	`/**`