Skip to content

Conversation

@michalsn
Copy link
Member

Description
This PR fixes two tests that were previously dependent on the current system time by setting a fixed time at the beginning of each test. This ensures consistent and deterministic test results.

Fixes #1280

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@datamweb datamweb added the testing Pull requests that changes tests only label Jul 16, 2025
Copy link
Collaborator

@datamweb datamweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, I don't like using humanize() in such tests. Look good to me.
Thanks!

@michalsn michalsn merged commit c1f903b into codeigniter4:develop Jul 16, 2025
35 of 36 checks passed
@michalsn
Copy link
Member Author

Thank you @datamweb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

testing Pull requests that changes tests only

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dev: Needs to be checked in the test

2 participants