-
Notifications
You must be signed in to change notification settings - Fork 143
feat: ignore robots when accessing magic link #1294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michalsn, thank you. I know the main focus of the discussion has been on the magic link, but I remember someone mentioning a similar issue regarding the activation link as well.
I’d like to know what your plan is regarding that issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
|
Since the list of bots was recently updated in CodeIgniter version 4.7, but Shield remains compatible with earlier versions, I think it would be helpful to mention in Shield’s documentation that the bot list can be updated through the app/Config/UserAgents.php file. |
|
@datamweb I have added the docs. We can add the same functionality to all actions in a separate PR. I think the right place for that would be https://github.com/codeigniter4/shield/blob/develop/src/Controllers/ActionController.php#L83, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks.
|
Thank you for your review! |
Description
This PR updates the magic link controller to ignore requests originating from bots or crawlers.
See #1293 for more details.
Checklist: