Fix(database): Prevent KeyError in parent sampling #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _enforce_population_limit function did not remove culled program IDs from self.archive and self.feature_map. This caused a KeyError when the sampling logic later tried to access a program ID that no longer existed in the main self.programs dictionary. This patch ensures that culled programs are removed from all relevant data structures, making the evolution process more robust.
|
|
|
This should be fixed in main now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical bug where the database could crash with a KeyError during parent sampling. The issue occurred because the population cleanup mechanism did not remove culled program IDs from the 'archive' and 'feature_map', leading to stale references. The patch ensures a complete cleanup, making the evolution process more robust.