Enforce console output checks in core unit tests #4073
Closed
+234
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+25
to
+42
| public void beforeEach(ExtensionContext context) { | ||
| CapturedStreams captured = new CapturedStreams(System.out, System.err); | ||
| getStore(context).put(context.getUniqueId(), captured); | ||
|
|
||
| System.setOut(captured.createInterceptingStream(captured.originalOut, captured.capturedOut)); | ||
| System.setErr(captured.createInterceptingStream(captured.originalErr, captured.capturedErr)); | ||
| } | ||
|
|
||
| @Override | ||
| public void afterEach(ExtensionContext context) { | ||
| CapturedStreams captured = | ||
| getStore(context).remove(context.getUniqueId(), CapturedStreams.class); | ||
| if (captured == null) { | ||
| return; | ||
| } | ||
|
|
||
| System.setOut(captured.originalOut); | ||
| System.setErr(captured.originalErr); |
There was a problem hiding this comment.
The extension unconditionally replaces the JVM‑wide System.out and System.err for each test run and restores them afterwards. That works when tests execute sequentially, but JUnit 5 allows concurrent execution and surefire can enable it via junit.jupiter.execution.parallel.enabled=true. With parallel tests, one invocation of beforeEach will overwrite the streams that another test is already using, and whichever afterEach runs last will restore the wrong streams. This leads to nondeterministic failures and, worse, some tests’ console output escaping the check entirely. Consider synchronizing access or opting out of parallel execution to ensure per‑test isolation.
Useful? React with 👍 / 👎.
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
|
✅ Native Android screenshot tests passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@AllowConsoleOutputannotation so specific tests can opt in to logging when requiredTesting
https://chatgpt.com/codex/tasks/task_e_68fb98e861f08331bc10960d53dfc050