feat(terminal): add toggle to enable/disable the built-in terminal #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new `enable` option in the terminal configuration to allow users to enable or disable the built-in terminal functionality entirely. Updated relevant logic to respect this setting, ensuring terminal-related features are only initialized and executed when enabled. - Added `enable` field to terminal config and default settings. - Updated terminal-related functions to check `is_enabled` before execution. - Enhanced documentation with instructions for external Claude Code usage. - Added unit tests to mock and validate `is_enabled` behavior. This change improves flexibility for users who prefer to disable the built-in terminal and use an external claude code instance.
|
Ohh there are already 2 PRs doing something similar 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new
enableoption in the terminal configuration to allow users to enable or disable the built-in terminal functionality entirely. Updated relevant logic to respect this setting, ensuring terminal-related features are only initialized and executed when enabled.enablefield to terminal config and default settings.is_enabledbefore execution.is_enabledbehavior.This change improves flexibility for users who prefer to disable the built-in terminal and use an external claude code instance.
<will shortly add demo screenshot/video of this>