-
Notifications
You must be signed in to change notification settings - Fork 68
[fix]: Fix NSDL CAS parser to correctly handle Mutual Fund Folios #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: brf153 <153hsb@gmail.com>
@codereverser I’m using |
Screen.Recording.2025-09-22.100534.mp4These are the packages |
Hi, could you try it with an older version of pymupdf, like before 1.25
(1.24.14 for eg)? I think something's messed up in the newer versions, and
I'm trying to figure it out.
Also, maybe install casparser with the fast extra? Just do `pip install -U
casparser[fast]`.
…On Mon, 22 Sept, 2025, 2:36 pm Devaansh Bhandari, ***@***.***> wrote:
*brf153* left a comment (codereverser/casparser#115)
<#115 (comment)>
https://github.com/user-attachments/assets/9c054194-7cb7-4fa9-85ae-320070bc4c33
These are the packages
—
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACBIEX7FATJDV3SWZ5TBIMD3T54EPAVCNFSM6AAAAACHDE2L7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTGMJWG4ZTONZWG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
sure. I will try it and let you know |
Thanks for checking! Yeah. there's something broken with pymupdf 1.25+ . I'm working on a new version with fixes and shall release it soon. |
@codereverser sure. You can check the updated regex in this PR — it might help with the new changes in the latest version of the PyMuPDF package. Thanks for your help! |
Problem
The parser was failing to handle Mutual Fund Folios sections due to:
DEMAT_MF_HEADER_RE
did not match the actual header format in CAS PDFs.current_demat
wasNone
, relevant lines were skipped, causing incomplete MF data extraction.Solution
current_demat
isNone
.Impact
This fix enables complete parsing of NSDL CAS statements containing Mutual Fund Folios alongside traditional demat accounts.