-
Notifications
You must be signed in to change notification settings - Fork 35
Add support for alternative outputs #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SevereOverfl0w
wants to merge
2
commits into
cognitect-labs:master
Choose a base branch
from
SevereOverfl0w:addoutputwrapping
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add support for alternative outputs #13
SevereOverfl0w
wants to merge
2
commits into
cognitect-labs:master
from
SevereOverfl0w:addoutputwrapping
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables writing JUnit output to a file, for CI purposes.
hkupty
added a commit
to hkupty/test-runner
that referenced
this pull request
May 15, 2019
This also borrows `require-and-resolve` from cognitect-labs#13.
hkupty
added a commit
to hkupty/test-runner
that referenced
this pull request
May 15, 2019
This also borrows `require-and-resolve` from cognitect-labs#13.
It's hard to confirm exactly what's happening, but this PR seems to not work when there are zero tests to run. Expected output:
With this PR:
{:clojure.main/message
"Syntax error (UnsupportedOperationException) compiling fn* at (REPL:0:0).\nUnknown Collection type\n",
:clojure.main/triage
{:clojure.error/phase :compile-syntax-check,
:clojure.error/line 0,
:clojure.error/column 0,
:clojure.error/symbol fn*,
:clojure.error/class java.lang.UnsupportedOperationException,
:clojure.error/cause "Unknown Collection type"},
:clojure.main/trace
{:via
[{:type clojure.lang.Compiler$CompilerException,
:message "Syntax error compiling fn* at (0:0).",
:data
{:clojure.error/phase :compile-syntax-check,
:clojure.error/line 0,
:clojure.error/column 0,
:clojure.error/source "NO_SOURCE_PATH",
:clojure.error/symbol fn*},
:at [clojure.lang.Compiler analyzeSeq "Compiler.java" 7119]}
{:type java.lang.UnsupportedOperationException,
:message "Unknown Collection type",
:at [clojure.lang.Compiler$EmptyExpr emit "Compiler.java" 2987]}],
:trace
[[clojure.lang.Compiler$EmptyExpr emit "Compiler.java" 2987]
[clojure.lang.Compiler$InvokeExpr
emitArgsAndCall
"Compiler.java"
3787]
[clojure.lang.Compiler$InvokeExpr emit "Compiler.java" 3729]
[clojure.lang.Compiler$BodyExpr emit "Compiler.java" 6164]
[clojure.lang.Compiler$TryExpr emit "Compiler.java" 2216]
[clojure.lang.Compiler$BodyExpr emit "Compiler.java" 6164]
[clojure.lang.Compiler$LetExpr doEmit "Compiler.java" 6523]
[clojure.lang.Compiler$LetExpr emit "Compiler.java" 6473]
[clojure.lang.Compiler$BodyExpr emit "Compiler.java" 6164]
[clojure.lang.Compiler$ObjMethod emitBody "Compiler.java" 5864]
[clojure.lang.Compiler$FnMethod doEmitStatic "Compiler.java" 5519]
[clojure.lang.Compiler$FnMethod emit "Compiler.java" 5484]
[clojure.lang.Compiler$FnExpr emitMethods "Compiler.java" 3948]
[clojure.lang.Compiler$ObjExpr compile "Compiler.java" 4584]
[clojure.lang.Compiler$FnExpr parse "Compiler.java" 4110]
[clojure.lang.Compiler analyzeSeq "Compiler.java" 7109]
[clojure.lang.Compiler analyze "Compiler.java" 6793]
[clojure.lang.Compiler eval "Compiler.java" 7178]
[clojure.lang.Compiler eval "Compiler.java" 7136]
[clojure.core$eval invokeStatic "core.clj" 3202]
[clojure.core$eval invoke "core.clj" 3198]
[cognitect.test_runner$test invokeStatic "test_runner.clj" 76]
[cognitect.test_runner$test invoke "test_runner.clj" 57]
[cognitect.test_runner$_main invokeStatic "test_runner.clj" 130]
[cognitect.test_runner$_main doInvoke "test_runner.clj" 119]
[clojure.lang.RestFn applyTo "RestFn.java" 137]
[clojure.lang.Var applyTo "Var.java" 705]
[clojure.core$apply invokeStatic "core.clj" 667]
[clojure.main$main_opt invokeStatic "main.clj" 514]
[clojure.main$main_opt invoke "main.clj" 510]
[clojure.main$main invokeStatic "main.clj" 664]
[clojure.main$main doInvoke "main.clj" 616]
[clojure.lang.RestFn applyTo "RestFn.java" 137]
[clojure.lang.Var applyTo "Var.java" 705]
[clojure.main main "main.java" 40]],
:cause "Unknown Collection type",
:phase :compile-syntax-check}} |
frenchy64
added a commit
to typedclojure/test-runner
that referenced
this pull request
Mar 22, 2021
griff
added a commit
to griff/test-runner
that referenced
this pull request
Mar 6, 2023
See PR #49 for a possible solution to this (as far as supporting junit and tap output). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My particular use-case is JUnit on CI systems, meaning two features are needed:
with-junit-output
around running the testsI have resolved both of these.
There is no standard parameterization system for clojure test output wrappers.
I think it is reasonable for users to create a macro which adds the parameters
they need, for parameterized output wrappers.