Skip to content

Conversation

@krishna1633
Copy link

@krishna1633 krishna1633 commented Dec 26, 2025

##Description

This PR SDK support for the two Limits API

Key Features

  • Data classes: LimitValueList
  • API methods: list & list_advanced
  • Integrated into CogniteClient as client.limits
  • Uses cdf-version: 20230101-alpha header for all requests

Additional Changes

  • Unit and integration tests for list & list_advanced method
  • Auto-generated sync API file (cognite/client/_sync_api/limits.py) via pre-commit hook

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • The PR title follows the Conventional Commit spec.

@krishna1633 krishna1633 requested review from a team as code owners December 26, 2025 06:05
@gemini-code-assist
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@krishna1633 krishna1633 marked this pull request as draft December 26, 2025 06:05
@krishna1633
Copy link
Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces list and list_advanced methods for the LimitsAPI, along with an iterator interface via __call__. This allows for both simple and filtered listing of limit values. The implementation includes corresponding data classes for lists and filters, updates to the synchronous API, documentation, and comprehensive unit and integration tests. The changes are well-structured and align with the existing SDK patterns. My review identifies one area for improvement related to adherence to the repository's testing guidelines.

@krishna1633 krishna1633 changed the title feat: add list && list_advanced feat: Added sdk support for listLimitsAdvanced && listLimits APIs Dec 26, 2025
@krishna1633 krishna1633 marked this pull request as ready for review December 26, 2025 16:52
@krishna1633 krishna1633 closed this Jan 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants