Revised build importer implementations

.scalafmt.conf

@@ -29,6 +29,9 @@ project {
     "glob:**/example/**/*-spotless*/**",
     "glob:**/javalib/test/resources/checkstyle/**",
     "glob:**/init/test/resources/giter8/hello.g8/src/main/g8/build.mill",
+    "glob:**/init/gradle/test/resources/**",
+    "glob:**/init/maven/test/resources/**",
+    "glob:**/init/sbt/test/resources/**",
     "glob:**/javalib/test/resources/javalib/palantirformat/**",
     "glob:**/integration/failure/parse-error/**",
     "glob:**/testkit/test/resources/example-test-example-project/build.mill",

example/migrating/javalib/3-maven-complete-large/build.mill

@@ -6,7 +6,9 @@
 > git remote add -f origin https://github.com/iluwatar/java-design-patterns
 > git checkout ede37bd05568b1b8b814d8e9a1d2bbd71d9d615d
 
-> ./mill init --jvm-id 21 # Repo needs Java >=21 to build and test
+> ./mill init
+
+> echo 21 > .mill-jvm-version # Repo needs Java >=21 to build and test
 
 > rm twin/src/test/java/com/iluwatar/twin/BallThreadTest.java # skip flaky test
 > rm actor-model/src/test/java/com/iluwatar/actor/ActorModelTest.java # skip flaky test

example/migrating/javalib/4-gradle-complete/build.mill

@@ -6,7 +6,7 @@
 > git remote add -f origin https://github.com/komamitsu/fluency.git
 > git checkout 2.7.3 # multi-module Java project that requires Java 16+
 
-> ./mill init --base-module FluencyModule --jvm-id 16
+> ./mill init
 converting Gradle build
 ...
 init completed, run "mill resolve _" to list available tasks

example/migrating/javalib/5-gradle-incomplete/build.mill

@@ -4,13 +4,12 @@
 
 > git init .
 > git remote add -f origin https://github.com/mockito/mockito.git
-> git checkout v5.15.2 # multi-module Java project that requires Java 17+
+> git checkout v5.19.0 # multi-module Java project
 
-> ./mill init --base-module MockitoModule --jvm-id 17   # init ignores custom dependency configurations
+> ./mill init --gradle-jvm-id 17  # imported modules are not fully functional
 converting Gradle build
-ignoring errorprone dependency (com.google.errorprone,error_prone_core,2.23.0)
 init completed, run "mill resolve _" to list available tasks
 
-> ./mill __.compile   # compilation error can be by fixed by using the Mill plugin for ErrorProne
-error: plug-in not found: ErrorProne
+> ./mill mockito-core.compile   # module jvmId needs tweaking
+error: java.lang.UnsupportedClassVersionError: com/google/errorprone/ErrorProneJavacPlugin has been compiled by a more recent version...
 */

example/migrating/scalalib/2-sbt-incomplete/build.mill

@@ -3,17 +3,15 @@
 > rm build.mill # remove any existing build file
 
 > git init .
-> git remote add -f origin https://github.com/tototoshi/scala-csv.git
-> git checkout 2.0.0
+> git remote add -f origin https://github.com/fthomas/refined.git
+> git checkout v0.11.3
 
 > ./mill init
 converting sbt build
 ...
 init completed, run "mill resolve _" to list available tasks
 
-> ./mill compile # You will have to further configure the `CrossScalaModule` for different Scala versions
-compiling 7 Scala sources and 3 Java sources to ...
-error: class CSVReader protected (private val lineReader: LineReader)(implicit format: CSVFormat) extends Closeable with CSVReaderCompat {
-error:                                                                                                                   ^
-error: one error found
+> ./mill modules.core.jvm[2.12.20].compile # source roots for custom version ranges need tweaking
+compiling 22 Scala sources to ...
+error: ...object boolean is not a member of package eu.timepit.refined
 */

integration/manual/migrating/src/MillInitGradleAsmTests.scala

@@ -0,0 +1,35 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleAsmTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 8.3
+      "https://gitlab.ow2.org/asm/asm.git",
+      "ASM_9_8",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "11"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("asm.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // tests are run using asm-test module?
+      eval("asm.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+
+      // custom sourceSets not supported
+      eval(
+        "tools.retrofitter.compile",
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleEhcache3Tests.scala

@@ -0,0 +1,27 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleEhcache3Tests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 7.2
+      "https://github.com/ehcache/ehcache3.git",
+      "v3.10.8",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "11"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // Gradle autoconfigures javac option -proc:none when -processorpath is not provided
+      eval("ehcache-api.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleFastCsvTests.scala

@@ -0,0 +1,29 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleFastCsvTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 9.0.0-rc-1, ErrorProne
+      "https://github.com/osiegmar/FastCSV.git",
+      "v4.0.0",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      // https://fastcsv.org/guides/contribution/
+      // requires JVM 25 as per docs, but it is missing in the coursier index
+      eval(
+        ("init", "--gradle-jvm-id", "24"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // Gradle autoconfigures javac option -proc:none when -processorpath is not provided
+      eval("lib.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleJCommanderTests.scala

@@ -0,0 +1,27 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleJCommanderTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    // Gradle 8.9
+    test - integrationTestGitRepo(
+      "https://github.com/cbeust/jcommander.git",
+      "2.0",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "11"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // annotations defined in main-module cannot be used in test-module?
+      eval("test.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleMicroconfigTests.scala

@@ -0,0 +1,26 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleMicroconfigTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    // Gradle 8.10.1
+    test - integrationTestGitRepo(
+      "https://github.com/microconfig/microconfig.git",
+      "v4.9.5",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "11"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleMockitoTests.scala

@@ -0,0 +1,27 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleMockitoTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 8.14.2, BOM module
+      "https://github.com/mockito/mockito.git",
+      "v5.19.0",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "17"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // ErrorProne requires JDK 17+ but module jvmId is 11
+      eval("mockito-core.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradlePCollectionsTests.scala

@@ -0,0 +1,30 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradlePCollectionsTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 8.14.3
+      "https://github.com/hrldcpr/pcollections.git",
+      "v5.0.0",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "17"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // typos in class names
+      eval("javadocGenerated", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+      // mismatch between junit-jupiter-api and junit-platform-launcher (from sbt jupiter-interface)
+      eval("test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleSpotbugsTests.scala

@@ -0,0 +1,38 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleSpotbugsTests extends GitRepoIntegrationTestSuite {
+
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 9.0.0
+      "https://github.com/spotbugs/spotbugs.git",
+      "4.9.4",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "17"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval(
+        "spotbugs-annotations.compile",
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval(
+        "spotbugs-annotations.publishLocal",
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+
+      // custom source folders not supported
+      eval("spotbugs-tests.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitGradleSpringFrameworkTests.scala

@@ -0,0 +1,28 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitGradleSpringFrameworkTests extends GitRepoIntegrationTestSuite {
+
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // Gradle 8.14.3, ErrorProne
+      "https://github.com/spring-projects/spring-framework.git",
+      "v6.2.11",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval(
+        ("init", "--gradle-jvm-id", "24"),
+        stdout = os.Inherit,
+        stderr = os.Inherit
+      ).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // BomModule not supported
+      eval("spring-core.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitMavenAntlr4Tests.scala

@@ -0,0 +1,23 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitMavenAntlr4Tests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      // polyglot project
+      "https://github.com/antlr/antlr4.git",
+      "4.13.2",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // custom layout not supported
+      eval("__.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}

integration/manual/migrating/src/MillInitMavenByteBuddyTests.scala

@@ -0,0 +1,24 @@
+package mill.integration
+
+import mill.testkit.GitRepoIntegrationTestSuite
+import utest.*
+
+object MillInitMavenByteBuddyTests extends GitRepoIntegrationTestSuite {
+  def tests = Tests {
+    test - integrationTestGitRepo(
+      "https://github.com/raphw/byte-buddy.git",
+      "byte-buddy-1.17.7",
+      linkMillExecutable = true
+    ) { tester =>
+      import tester.*
+
+      eval("init", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("__.showModuleDeps", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+      eval("byte-buddy-agent.test", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> true
+
+      // requires Android support
+      // Gradle plugin is built using Gradle
+      eval("__.compile", stdout = os.Inherit, stderr = os.Inherit).isSuccess ==> false
+    }
+  }
+}