-
-
Notifications
You must be signed in to change notification settings - Fork 419
document-more-complex-task-usecases #5816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
arminsumo
wants to merge
3
commits into
com-lihaoyi:main
from
arminsumo:document-more-complex-task-usecases
Closed
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 changes: 62 additions & 0 deletions
62
example/fundamentals/tasks/8-inheritance-and-chaining/build.mill
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,62 @@ | ||
package build | ||
import mill.* | ||
import mill.api.TaskCtx | ||
|
||
trait BaseModule extends Module { | ||
def generate = Task { | ||
val output = Task.dest / "generated.txt" | ||
os.write(output, "hello") | ||
PathRef(output) | ||
} | ||
} | ||
|
||
// This module uses the base implementation unchanged | ||
// Calling generate here will create: | ||
// out/moduleA/generate.dest/generated.txt | ||
object moduleA extends BaseModule | ||
|
||
// When overriding tasks, never modify the parent task's output. | ||
// Instead, create new output in your own task's destination folder | ||
// Here we will generate two files in the output: | ||
// out/moduleB/generate.super/BaseModule.dest/generated.txt (parent output) | ||
// out/moduleB/generate.dest/processed.txt (this module's output) | ||
// Note: We can not over write the original contents of | ||
// generated.txt, because it is in a different output destination | ||
object moduleB extends BaseModule { | ||
override def generate = Task { | ||
val parentResult = super.generate() | ||
val parentContent = os.read(parentResult.path) | ||
val processed = parentContent | ||
.replaceAll("hello", "world") | ||
.trim | ||
|
||
writeData(processed, "processed.txt") | ||
} | ||
|
||
// Helper function for writing data within a task context | ||
// Note: This is a regular function, not a Task, so it can accept | ||
// runtime parameters. It uses implicit TaskCtx to access Task.dest | ||
private def writeData(data: String, name: String)(implicit ctx: TaskCtx): PathRef = { | ||
val outputPath = ctx.dest / name | ||
os.write(outputPath, data) | ||
PathRef(outputPath) | ||
} | ||
} | ||
|
||
// We can also acheive similar results by chaining tasks together. | ||
object moduleC extends BaseModule { | ||
override def generate = Task { | ||
processGenerated() | ||
} | ||
|
||
def processGenerated = Task { | ||
val parentResult = super.generate() | ||
val parentContent = os.read(parentResult.path) | ||
val processed = parentContent | ||
.replaceAll("hello", "world") | ||
.trim | ||
val outputPath = Task.dest / "processed.txt" | ||
os.write(outputPath, processed) | ||
PathRef(outputPath) | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"as this would break caching." is wrong. It's not about caching, but definition/dependency order.
Since we need to know the parameters before creating the task, but the tasks need to be created before we can start evaluation, we have a classic hen-or-egg problem.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are three strategies to resolve this:
def