Skip to content

Convert scriptSourcesPaths to a Task.Input #5956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Convert scriptSourcesPaths to a Task.Input #5956

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions runner/meta/src/mill/meta/MillBuildRootModule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,19 +41,19 @@ trait MillBuildRootModule()(using

override def scalaVersion: T[String] = BuildInfo.scalaVersion

val scriptSourcesPaths = BuildCtx.watchValue {
BuildCtx.withFilesystemCheckerDisabled {
FileImportGraph
.walkBuildFiles(rootModuleInfo.projectRoot / os.up, rootModuleInfo.output)
.sorted // Ensure ordering is deterministic
}
}

/**
* All script files (that will get wrapped later)
* @see [[generatedSources]]
*
* This is a `Task.Input` rather than a `Task.Source` to avoid creating a
* `PathRef(workspaceRoot)` which would be a very expensive operation since it
* would need to hash the `out/` folder and all its generated files
*/
def scriptSources: T[Seq[PathRef]] = Task.Sources(scriptSourcesPaths*)
def scriptSources: T[Seq[PathRef]] = Task.Input {
FileImportGraph
.walkBuildFiles(rootModuleInfo.projectRoot / os.up, rootModuleInfo.output)
.sorted // Ensure ordering is deterministic
.map(PathRef(_))
}

def parseBuildFiles: T[FileImportGraph] = Task {
BuildCtx.withFilesystemCheckerDisabled {
Expand Down
Loading